-
Notifications
You must be signed in to change notification settings - Fork 125
Index creation #2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VictoriaSavageNNL
wants to merge
31
commits into
linkml:main
Choose a base branch
from
NavalNuclearLab:index_creation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Index creation #2775
+100
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the right-hand side of the page, under the 'Reviewers' section, there's a link you can click to convert this PR to draft status. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
==========================================
+ Coverage 82.94% 82.98% +0.04%
==========================================
Files 126 126
Lines 13924 13963 +39
Branches 3885 3896 +11
==========================================
+ Hits 11549 11587 +38
Misses 1729 1729
- Partials 646 647 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ialarmedalien
reviewed
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the creation of Indexes through generate_ddl. Indexes are created both automatically on primary keys, foreign keys, and unique constraints, and by being specified in the annotations of a given class. Additional checks are given to ensure duplicate names aren't created.
Future work should adjust the runtime model to enable an index field in a class definition
This address Issue #1910