GWL: add notification badges to panel icons #12569
Conversation
|
Yes, new features don't go in past BETA. |
|
I don't know if I like the two numbers side by side (it excludes a big portion of the top of the icon and presents two conflicting pieces of information side by side, requiring more effort than necessary to interpret the values since they are very close, despite having different colors). We could try to think of a better way to present that information until the next merge period for the next release. |
Why? I'm not using a phone OS |
There was a problem hiding this comment.
Pull Request Overview
This PR adds new notification badges for panel icons by introducing a separate badge for notifications along with the existing window count badge and removes the "Show window count numbers" configuration. Key changes include:
- Passing a new desktopEntry hint to notifications in both notificationDaemon.js and messageTray.js.
- Adding event handling for notification updates in workspace.js.
- Overhauling the appGroup.js code to support separate badges for windows and notifications.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| js/ui/notificationDaemon.js | Updated notification creation to include the desktopEntry hint. |
| js/ui/messageTray.js | Extended Notification class and documentation to support desktopEntry. |
| files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/workspace.js | Added connection to notify-applet-update and a new notificationReceived handler. |
| files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/applet.js | Removed the obsolete updateWindowNumberState function. |
| files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/appGroup.js | Modified badge layout and introduced methods for updating notification and window count badges. |
Files not reviewed (3)
- data/theme/cinnamon-sass/_colors.scss: Language not supported
- data/theme/cinnamon-sass/widgets/_windowlist.scss: Language not supported
- files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/settings-schema.json: Language not supported
files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/appGroup.js
Outdated
Show resolved
Hide resolved
|
@anaximeno How about in opposite corners. I can't think of anything else that will work with all themes except badges. |
It looks better this way you did it now, in my opinion. Good choice.
Yeah, the options are limited thanks to that. |
and remove "Show window count numbers" config option.
1235bc4 to
b33185a
Compare
...so that they're also removed from notifications applet and other instances of GWL applet + decrement badge when individual notifications are destroyed. + add 'notification' role in case notifications applet not running
+ ensure all instances of an app have the same notification count.
Continuing on from the great work by @romario-07 in #12561 this adds a different color notification badge on the right of the icon and both badge sizes are adjusted automatically to the size of the icon. The "Show window count numbers" config option is removed as it seems fairly pointless.
@clefebvre @mtwebster Is this too late for the beta?
28px panel:40px panel (Mint default):48px panel:The issue mentioned in this comment is fixed.
In Mint-Y, 40 px:closes #10124
Edit: Changed window count badge to bottom left and adjusted notification color: