8000 Modernize kb layouts by mtwebster · Pull Request #12758 · linuxmint/cinnamon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modernize kb layouts #12758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Modernize kb layouts #12758

wants to merge 24 commits into from

Conversation

mtwebster
Copy link
Member
@mtwebster mtwebster commented Feb 25, 2025
  • Move from libgnomekbd, xapp for input switching
  • Modernize settings
  • Modernize keyboard layout applet
  • Discontinue osk use of caribou
  • support completion using ibus
  • review Cinnamon dependencies
  • review mintlocale input-method configuration
  • review csd-*
  • remove c-c-c region module
  • review cinnamon-screensaver

requires:

notes:

ref: linuxmint/wayland#14

@silverhadch
Copy link

How do we compile it and install it tho?

@pewgar
Copy link
pewgar commented Mar 15, 2025

the layouts tab still doesn't show up in the keyboard settings, terminal?

@mtwebster
Copy link
Member Author

the layouts tab still doesn't show up in the keyboard settings, terminal?

It should..
image

Are there any errors when running cinnamon-settings keyboard from a terminal? Did you build and install the cinnamon-desktop branch also?

@mtwebster
Copy link
Member Author

How do we compile it and install it tho?

In Mint you should be able to clone this repo, and build using dpkg-buildpackage, otherwise you use meson directly to build it. Honestly, if you're not already comfortable doing this sort of thing I would avoid this and wait, as there's a good chance you could make your system (temporarily, at least) unusable.

@silverhadch
Copy link
silverhadch commented Mar 16, 2025

@mtwebster
it produced an non functional Cinnamon both Sessions but thank God i used BTRFS and was back up running in a minute. (should really be the default or better selectable instead of manuall partitioning)

The Xorg session was missing the panel and the Wayland session crashed after 10 seconds and only showed the cursor.

8000

@pewgar
Copy link
pewgar commented Mar 16, 2025

the layouts tab still doesn't show up in the keyboard settings, terminal?

It should.. image

Are there any errors when running cinnamon-settings keyboard from a terminal? Did you build and install the cinnamon-desktop branch also?

oh, dw im just a normie and for whatever reason said something stupid without having this installed. i'll wait for this to be added into the system

@mtwebster mtwebster force-pushed the modernize-kb-layouts branch 2 times, most recently from 6ed656c to 6998441 Compare March 31, 2025 13:07
@MagicBOTAlex
Copy link

Just donated 5 EUR (The website says 5$ though). Not much, since I normally don't contribute.

But hopefully Wayland on Mint soon! (I NEED FRACTIONAL SCALING)

Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 96 out of 100 changed files in this pull request and generated 2 comments.

Files not reviewed (4)
    10000
  • data/README.osk-layouts: Language not supported
  • data/cinnamon-osk-layouts.gresource.xml: Language not supported
  • data/cldr2json/test/data/fr-t-k0-android.xml: Language not supported
  • data/meson.build: Language not supported
Comments suppressed due to low confidence (1)

data/cldr2json/cldr2json.py:126

  • Consider correcting the spelling in the error message: 'explicitely' should be 'explicitly'.
raise KeyError("layout %s explicitely disabled in overrides" % locale)

Comment on lines +202 to +203
class LoadXKBMapplings(unittest.TestCase):
def test_dictionnary(self):
Copy link
Preview
Copilot AI Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name 'LoadXKBMapplings' appears to be misspelled. Consider renaming it to 'LoadXKBMappings'.

Suggested change
class LoadXKBMapplings(unittest.TestCase):
def test_dictionnary(self):
class LoadXKBMappings(unittest.TestCase):

Copilot uses AI. Check for mistakes.



class LoadXKBMapplings(unittest.TestCase):
def test_dictionnary(self):
Copy link
Preview
Copilot AI Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method name 'test_dictionnary' contains a misspelling; 'dictionary' is likely the intended word.

Suggested change
def test_dictionnary(self):
def test_dictionary(self):

Copilot uses AI. Check for mistakes.

@pewgar

This comment was marked as spam.

mtwebster and others added 22 commits April 29, 2025 14:27
This is only handling xkb layouts for now, ibus is coming...
- remove popup switcher, mru tracking.
- add type column to add-layout-dialog, show columns
- add org.cinnamon.desktop.input-sources to panel troubleshooting->reset
- fix keybinding setter widget
- populate 'sources' and xkboptions from /etc/default/keyboard values.
- don't let layout settings change the active layout thru selection.
- Fix viewing layout from the applet menu
- Fix sorting, heading for the add layout dialog
- Fix syncing of keybindings between keyboard settings and xlet
  and various individual setting pages.
Multiple layouts can be defined here.
@mtwebster mtwebster force-pushed the modernize-kb-layouts branch from 3510e2e to 83a5902 Compare May 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0