8000 fix: add missing dependency by rickstaa · Pull Request #281 · livepeer/explorer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add missing dependency #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: add missing dependency #281

wants to merge 8 commits into from

Conversation

rickstaa
Copy link
Member
@rickstaa rickstaa commented Feb 22, 2025 •
edited
Loading

This commit adds the @radix-ui/react-tooltip package as a dependency to fix an error during build. This error was caused by the explorer relying on the dependency in the https://github.com/livepeer/design-system package:

Important

Rebased on top of #282 to showcase it works. Please merge after #282.

Show error 
Type error: Type '{ children: ReactNode & ReactElement<any, string | JSXElementConstructor<any>>; asChild: true; }' is not assignable to type 'IntrinsicAttributes & TooltipTriggerProps & RefAttributes<HTMLButtonElement>'.
  Property 'children' does not exist on type 'IntrinsicAttributes & TooltipTriggerProps & RefAttributes<HTMLButtonElement>'.

  42 |       
  43 |     >
> 44 |       <TooltipPrimitive.Trigger asChild>{children}</TooltipPrimitive.Trigger>
     |        ^
  45 |
  46 |       <Content
  47 |         side="top"

> Build error occurred
Error: Call retries were exceeded
    at ChildProcessWorker.initialize (/home/ricks/development/livepeer/other/explorer/node_modules/next/dist/compiled/jest-worker/index.js:1:11661)
    at ChildProcessWorker._onExit (/home/ricks/development/livepeer/other/explorer/node_modules/next/dist/compiled/jest-worker/index.js:1:12599)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
  type: 'WorkerError'
}
error Command failed with exit code 1.

@vercel Vercel
Copy link
vercel bot commented Feb 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-arbitrum-one ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 6:36pm

@rickstaa rickstaa requested a review from victorges February 22, 2025 09:45
rickstaa and others added 8 commits February 22, 2025 12:36
@rickstaa @JJassonn69
fix: updates codegen subgraph
187b90f 
This commit updates the subgraph that is used for the apollo type
generation to the [decentralised subgraph](https://thegraph.com/explorer/subgraphs/FE63YgkzcpVocxdCEyEYbvjYqEf2kb1A6daMYRxmejYC?view=Query&chain=arbitrum-one#query-subgraph)
now that the hosted subgraph is deprecated.

Co-authored-by: "Jason.Stone" <ganesh_friend2010@yahoo.com>
@rickstaa @JJassonn69
fix: fix graphql types linting errors
c09a848 
This commit fixes linting errors which were now thrown since we updated
the GraphQL spec.

Co-authored-by: Co-authored-by: "Jason.Stone" <ganesh_friend2010@yahoo.com>
@rickstaa
refactor: cleanup DelegatorWidget types
86481fe 
This commit ensures that we don't declare the `TranscoderOrDElegateType`
multiple times but reuse it.
@rickstaa
feat: make 'NEXT_PUBLIC_SUBGRAPH_API_KEY' required
4ac9b8e 
This makes the 'NEXT_PUBLIC_SUBGRAPH_API_KEY' environment variable
required now that the hosted subgraph is deprecated. It also removes the
fallback logic to the hosted subgraph.
@rickstaa
fix: update subgraph fallback ID
9ff5277 
This commit updates the subgraph fallback ID to the new decentralised
subgraph.
@rickstaa
chore: add subgraph ID to env example
1563953 
This commit adds the Livepeer decentralised subgraph ID to the env
example file since it is required for `yarn codegen`.
@rickstaa
refactor: change require env check logic
32516e1 
This commit improves the check for required environmental variables to
prevent confusion when thse variables are in the `.env` file but
empty.
@rickstaa
fix: add missing dependency
ca20168 
This commit adds the `@radix-ui/react-tooltip` package as a dependency
to fix an error during build. This error was caused by the explorer
relying on the dependency in the
https://github.com/livepeer/design-system package.
@rickstaa rickstaa force-pushed the add_yarn_build_error branch from 93cc452 to ca20168 Compare February 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges Awaiting requested review from victorges

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rickstaa
0