-
Notifications
You must be signed in to change notification settings - Fork 15
Full Transparency to Voting History feature to be implemented within the Livepeer Explorer #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liamdoyle95
wants to merge
38
commits into
livepeer:main
Choose a base branch
from
liamdoyle95:AddVotingTransparency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Start of voting transparency intergration -Experiencing fetch limits with infura
-Data renders -UI to work on with Arb Txn -UI for Mobile and Desktop -Test popOver and all associated links
-Converted from Tailwind to Livepper CSS format -Improved UI / UX
-Voting popover now rendering -Need to fix logic to prevent voting from also closing when closed.
-Voting popover close now doesnt also close voting data -Voting Cards do not show over Navbar when cross.
-ENS now fetches latest registrered ENS, no matter when it was created. Ensuring its the right one. -Arbicscan link no longer closes votes dropdown and onHover UI
ENS to be added
…ace within codebase
-Moved duplicated code and import it into multiple components that use it. -Desktop and mobile votes split and will lazy load to optimise perfomance of loading votes for user. -Fixed UX issue that I found. The voter votes history on click off would close all vote list not just popover. Also improved some UI for close button along with logic to only close popover.
- Since refactoring code, some of this was no longer needed in here. -Added Number of votes alongside view votes. -Added info for user to view popover.
-Voting feature hooks now situated in final location within codebase. -Hydration errors fix.
…er within their own graphql files
-Infura used for votes here not subgraph as data isnt available for all votes -Vote reverted back to using interface within lib/api/types/votes
@liamdoyle95 is attempting to deploy a commit to the Livepeer Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
-VoteTx changed from Arbiscan Icon to formatted voteTx address -UI for table heading
…5/explorerVotingTransparency into AddVotingTransparency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Work carried out satisfies grant deliverables for livepeer/grants#300.