-
Notifications
You must be signed in to change notification settings - Fork 72
add duration check for input files #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add duration check for input files #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a unit test. It would also be nice to have a case where we have a long video that does not trigger this check (eg, input via pipe) but do you have an idea of how heavy of a test that would be?
@j0sh I added two tests. One tests good and bad segments using file inputs. Second test uses a pipe input with 301 second input that does not trigger an error. |
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
Simplified the tests in 93a85e7 |
Fix to test input segments for durations longer than 5 minutes.
Fixes bug that created ridiculously large output segments.
long-ts.log
wrong-ts.log
cc @rickstaa