8000 add duration check for input files by ad-astra-video · Pull Request #434 · livepeer/lpms · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add duration check for input files #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 29, 2025

Conversation

ad-astra-video
Copy link
Contributor
@ad-astra-video ad-astra-video commented May 27, 2025

Fix to test input segments for durations longer than 5 minutes.

Fixes bug that created ridiculously large output segments.

long-ts.log
wrong-ts.log

cc @rickstaa

Copy link
Collaborator
@j0sh j0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a unit test. It would also be nice to have a case where we have a long video that does not trigger this check (eg, input via pipe) but do you have an idea of how heavy of a test that would be?

@ad-astra-video
Copy link
Contributor Author

@j0sh I added two tests. One tests good and bad segments using file inputs. Second test uses a pipe input with 301 second input that does not trigger an error.

j0sh
ad-astra-video and others added 5 commits May 28, 2025 05:21
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
@j0sh
Copy link
Collaborator
j0sh commented May 29, 2025

Simplified the tests in 93a85e7

@ad-astra-video ad-astra-video merged commit c1eefa6 into livepeer:master May 29, 2025
2 of 3 checks passed
@ad-astra-video ad-astra-video deleted the add-duration-check branch May 29, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0