[HWCleanUp] Don't fuse always_comb #5175
Jump to bottom
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's reasonable to just remove it for now. We could also file a ticket to potentially add it back with more in-depth analysis about what fusion is legal, since it might still be possible in some cases. |
8000
|
Yes, I think it would require very complicated analysis to safely fuse the always comb blocks in general. So I'd like to just remove the optimization for the correctness for now. |
mikeurbach
approved these changes
May 17, 2023
|
@uenoku is this ready to be merged? |
|
Yes, thank you for pinging me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's illegal to merge different always_comb as it might implicitly have data dependency each other. Fix #5171