[HandshakeToDC] Add conversion #5214
Conversation
| // operations which have been converted as legal, and all other operations | ||
| // as illegal. | ||
| target.markUnknownOpDynamicallyLegal( | ||
| [&](Operation *op) { return convertedOps.contains(op); }); |
There was a problem hiding this comment.
Are you adding new handshake operations or why is this required?
There was a problem hiding this comment.
This is needed for all of the arith ops that get created as part of the handshake ops (e.g. arith.select for handshake.mux). There's a bit of a dilemma here seeing as all operations need to be converted/touched in a handshake.func - which is done so by UnitRateConversionPattern (when no other pattern applies). However, we obviously don't want to run that pattern on these newly created ops since they do not have handshake semantics... suggestions are welcome 🙂!
There was a problem hiding this comment.
Alright, now I understand the problem. So given the current handshake design, this is indeed necessary.
... progressive lowering of handshake! This obviously requires a future addition of an `arith-to-comb/hw` pass to map arith stuff to comb/external hardware/pipelines, ...
8fa31c5 to
e5ba263
Compare
| // operations which have been converted as legal, and all other operations | ||
| // as illegal. | ||
| target.markUnknownOpDynamicallyLegal( | ||
| [&](Operation *op) { return convertedOps.contains(op); }); |
There was a problem hiding this comment.
Alright, now I understand the problem. So given the current handshake design, this is indeed necessary.
| ConvertedOps *convertedOps) | ||
| : OpConversionPattern<OpTy>(typeConverter, context), | ||
| convertedOps(convertedOps) {} | ||
| mutable ConvertedOps *convertedOps; |
There was a problem hiding this comment.
It's a shame that one cannot register listeners on the rewriter to get out the set of created ops in a clean manner.
... progressive lowering of handshake!
This obviously requires a future addition of an
arith-to-comb/hwpass to map arith stuff to comb/external hardware/pipelines, ...