[SV] Add lowering option to emit separate always blocks #5211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
May 17, 2023
There was a problem hiding this comment.
The change for LowerSeqToSV looks good to me. I feel it's not even necessary to run HWCleanUp in the presence of the option as HWCleanUp currently only fuses statements. Besides, probably we don't want to make emitSeparateAlwaysBlocks part of LoweringOptions, as LoweringOptions is only for verilog generation, not for IR lowering.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
5ad1248 to
5403539
Compare
|
I've removed the option from |
youngar
reviewed
May 17, 2023
5403539 to
73e18f1
Compare
youngar
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HWCleanupis changed to prevent coalescing blocks.LowerFIRRTLSeqToSValso receives the argument to avoid emitting assignments in the same block in the first place.