[Seq][HW] Add a macro to enable register initializers #5222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ENABLE_INITIAL_REG_` is used to permit fine-grained control over register initializers. It is always defined if `SYNTHESIS` is not defined, but it can also be externally overridden.
138f0db to
4a8db97
Compare
seldridge
approved these changes
May 19, 2023
There was a problem hiding this comment.
LGTM
I like the more fine-grained ability to choose what you want. I'd argue this actually cleans up the emitted Verilog by guarding blocks with defines that describe what they are doing as opposed to SYNTHESIS which is an omnibus option.
We should roll this out for all SYNTHESIS-related options and then make these macros defined in the FIRRTL ABI. I'm going to see if @carlosedp can update #5203 to use this style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_INITIAL_REG_is used to permit fine-grained control over register initializers. It is always defined ifSYNTHESISis not defined, but it can also be externally overridden.