[SystemC] integration tests: avoid compile_commands.json in clang-tidy. #5239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CXX compiler is not clang (or not same clang as clang-tidy used), build flags may not be appropriate (or valid) for use by clang-tidy. Workaround by adding trailing '--'. Fixes llvm#5236. See upstream llvm/llvm-project@626849c .
|
If we are expecting clang-tidy to know about the systemc headers we may need to specify that here explicitly with this change (?). Have not confirmed to resolve the nightly test issue, but this is how upstream resolved similar problem. |
teqdruid
approved these changes
May 22, 2023
|
Let's give it a try, then. Thanks! |
|
Looks like these configurations are now fixed in nightly! Still fails due to valgrind issue, will file issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CXX compiler is not clang (or not same clang as clang-tidy used), build flags may not be appropriate (or valid) for use by clang-tidy.
Workaround by adding trailing '--'.
Fixes #5236.
See upstream
llvm/llvm-project@626849c .