8000 [FIRRTL] Reject ref statements for some ports but not all. by dtzSiFive · Pull Request #5233 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FIRRTL] Reject ref statements for some ports but not all. #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

[FIRRTL] Reject ref statements for some ports but not all. #5233

merged 1 commit into from
May 19, 2023

Conversation

dtzSiFive
Copy link
Contributor

For use w/deferred linking or the new ABI, ref statements are not required. However, if they're present they must cover all ref ports on the module.

cc #4909.

@dtzSiFive
[FIRRTL] Reject ref statements for some ports but not all.
128a3c8 
For use w/deferred linking or the new ABI, ref statements
are not required.  However, if they're present they must cover
all ref ports on the module.

cc llvm#4909.
@dtzSiFive dtzSiFive requested a review from prithayan May 19, 2023 17:26
prithayan
prithayan approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor
@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dtzSiFive dtzSiFive merged commit 5e3b503 into llvm:main May 19, 2023
@dtzSiFive dtzSiFive deleted the fix/no-partial-ref-statement-coverage branch May 19, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prithayan prithayan prithayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @prithayan
0