[CI] Add macos wheels #5249
[CI] Add macos wheels #5249
Conversation
|
This seems to be working here: https://github.com/llvm/circt/actions/runs/5060542988, but if I look at other runs (https://github.com/llvm/circt/actions/runs/5009139934), I see errors. So it looks like there are transient errors possible... |
Digging into it, I see actual C++ build errors: https://github.com/llvm/circt/actions/runs/5009139934/jobs/8977750389#step:6:2362. Doesn't seem like anything to do with macos/python/buildwheel. Any idea why this comes up? It also seems non-deterministic, i.e. it works sometimes. |
|
This error looks like a basic dependency issue, I can take a look at it or @mortbopet , @RamirezLucas , and @Dinistro might have an idea, since it is on the conversion to handshake. Probably this is just exposed by this environment for some reason. In general looks great, thanks for trying this out and testing it! |
|
Looks like this line is just missing in StandardToHandshake: circt/lib/Conversion/ExportVerilog/CMakeLists.txt Lines 12 to 13 in 6bc7e7b |
This dependency is needed to generate the shared Passes.{h,cpp}.inc
files used by all conversion passes. Add it in a few places it was
missing. This should resolve flaky compile errors, like we saw in
#5249.
|
Should be fixed after 9d924a6. |
6375f4d to
4373356
Compare
|
Thanks for the prompt action @mikeurbach ! Rebased. See https://github.com/llvm/circt/actions/runs/5062704176 for the latest run. |
|
@mikeurbach also, once this is in, what is the path to making a firtool release to get the packages to pypi? |
|
We have regular firtool releases created weekly by folks from SiFive, so this will be included in the next release and the wheels pushed to PyPI when it is cut. |
No description provided.