8000 [FIRParser] Support keywords and literal identifiers as static ref exprs. by dtzSiFive · Pull Request #5252 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FIRParser] Support keywords and literal identifiers as static ref exprs. #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2023
Merged

[FIRParser] Support keywords and literal identifiers as static ref exprs. #5252

merged 1 commit into from
May 24, 2023

Conversation

dtzSiFive
Copy link
Contributor

Add test.

@dtzSiFive dtzSiFive requested review from seldridge and prithayan May 24, 2023 18:12
seldridge
seldridge approved these changes May 24, 2023
View reviewed changes
Copy link
Member
@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed test, thanks!

@dtzSiFive dtzSiFive merged commit 75bdc97 into llvm:main May 24, 2023
@dtzSiFive dtzSiFive deleted the feature/ref-expr-more-than-id branch May 24, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@prithayan prithayan Awaiting requested review from prithayan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @seldridge
0