[Arc] Improve icmp canonicalization pattern #5266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
May 25, 2023
|
I wonder if the notion of pulling arithmetic ops through concats is something that's beneficial in general, to ensure we do as much work before we ever have to concatenate or extract. |
|
It's probably always beneficial when some kind of reduction is done on the concatenated value directly, otherwise we probably need to check if there are some extracts or so happening 'a bit later' that allow the concat to disappear (or at least some operands of it), but that the additional operations we might need to add when pushing them through are still cheaper than just doing the concat. That would need some more complex analysis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~1.2x speedup on riscinator (or ~1.28x when VCD tracing disabled)