8000 Remove explicit phase annotations by rwy7 · Pull Request #5262 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove explicit phase annotations #5262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Remove explicit phase annotations #5262

merged 1 commit into from
May 25, 2023

Conversation

rwy7
Copy link
Contributor
@rwy7 rwy7 commented May 25, 2023

Rather than tracking phases at a fine-grained level in the types, we are going to be tracking phase at the granularity of ports.

@rwy7 rwy7 requested review from youngar and dtzSiFive May 25, 2023 18:37
dtzSiFive
dtzSiFive approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor
@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backs out the string-related changes re:phase type interface usage (only user so far in landed PR's), right?

LGTM!

Should this (or follow-on) also remove the phase type interface?

@rwy7
Copy link
Contributor Author
rwy7 commented May 25, 2023 •
edited
Loading

This backs out the string-related changes re:phase type interface usage (only user so far in landed PR's), right?

Yep!

Should this (or follow-on) also remove the phase type interface?

I think I'm going to keep the phased type interface, and will use it to validate what types can appear in a property-port.

@dtzSiFive
Copy link
Contributor

I think I'm going to keep the phased type interface, and will use it to validate what types can appear in a property-port.

Oh!! Yeah, totally, my mistake. Sounds great! 👍 .

youngar
youngar approved these changes May 25, 2023
View reviewed changes
@rwy7
Copy link
Contributor Author
rwy7 commented May 25, 2023

Nevermind, I am removing the phased type interface after all 🥲

@rwy7 rwy7 merged commit b9eddc3 into llvm:main May 25, 2023
@rwy7 rwy7 deleted the type-phases branch May 25, 2023 21:09
@dtzSiFive dtzSiFive mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngar youngar youngar approved these changes

@dtzSiFive dtzSiFive dtzSiFive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwy7 @dtzSiFive @youngar
0