8000 Move cocotb driver to separate tool by mortbopet · Pull Request #5279 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move cocotb driver to separate tool #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account 8000

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

mortbopet
Copy link
Contributor

Turns out the cocotb driver is useful for things other than handshake... moves the cocotb driver to a separate tool folder, and modifies handshake tests accordingly.

Turns out the cocotb driver is useful for things other than handshake... moves the cocotb driver to a separate tool folder, and modifies handshake tests accordingly.
Copy link
Contributor
@lucas-rami lucas-rami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with one small formatting nit)!

default=os.getcwd(),
help="The folder where the cocotb test file is.")
argparser.add_argument("--pythonFolders",
type=str,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: weird indent? Not sure about Python formatting

Copy link
Contributor
@Dinistro Dinistro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mortbopet mortbopet merged commit 9df2cf4 into main May 30, 2023
@darthscsi darthscsi deleted the dev/mpetersen/cocotb_driver2 branch June 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0