[FIRRTL][InferWidths] Make solveExpr Iterative #5305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
744d8b0 to
d402260
Compare
uenoku
reviewed
Jun 1, 2023
uenoku
reviewed
Jun 2, 2023
|
|
||
| // indent only used for debug logs. | ||
| unsigned indent = 1; | ||
| std::vector<Frame> worklist({{expr, indent}}); |
There was a problem hiding this comment.
nit: Is there a specific reason to use std::vector over SmallVector?
There was a problem hiding this comment.
I don't think so, the worklist can grow pretty large, we can switch to smallvector, how does the logic for reserve look to you ? I reserved the number of exprs/2 size for this.
There was a problem hiding this comment.
I don't have good intuition for the constraint but exprs/2 sounds reasonable.
This is not working. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
67390b9 to
035acfe
Compare
|
The pre-merge-ci tests were clean, going to merge this, for the next circt release. |
youngar
added a commit
to youngar/circt
that referenced
this pull request
Oct 9, 2024
We would allocate a new workstack each time we solve a var, and reserve a size of 1/2 of the total number of expressions. The number of expressions in a ciruit is absolutely massive, making this not a good default. Instead, we just allocate the workstack from outside of the method and reuse the memory allocation for each solve. As an aside, this fixes the indentation for debug printing which was broken in llvm#5305.
youngar
added a commit
to youngar/circt
that referenced
this pull request
Oct 9, 2024
We would allocate a new workstack each time we solve a var, and reserve a size of 1/2 of the total number of expressions. The number of expressions in a ciruit is absolutely massive, making this not a good default. Instead, we just allocate the workstack from outside of the method and reuse the memory allocation for each solve. As an aside, this fixes the indentation for debug printing which was broken in llvm#5305.
youngar
added a commit
that referenced
this pull request
Oct 12, 2024
We would allocate a new workstack each time we solve a var, and reserve a size of 1/2 of the total number of expressions. The number of expressions in a ciruit is absolutely massive, making this not a good default. Instead, we just allocate the workstack from outside of the method and reuse the memory allocation for each solve. As an aside, this fixes the indentation for debug printing which was broken in #5305.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
solveExprimplementation ofInferWidthswas recursive and causing stack overflow issues on some designs.This PR implements an iterative version of the algorithm.
Co-authored-by: Schuyler Eldridge schuyler.eldridge@sifive.com