10000 [ESI][Runtime] Don't pull down JSON dependency if already defined by teqdruid · Pull Request #7033 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ESI][Runtime] Don't pull down JSON dependency if already defined #7033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2024
Merged

[ESI][Runtime] Don't pull down JSON dependency if already defined #7033

merged 1 commit into from
May 14, 2024

Conversation

teqdruid
Copy link
Contributor

Since nlohmann_json is a pretty common dependency, if that target already exists, don't re-download it and run its CMakeLists. This is helpful when the ESI runtime is being itself fetched through cmake FetchContent.

@teqdruid teqdruid added the ESI label May 14, 2024
@teqdruid teqdruid merged commit b51a644 into main May 14, 2024
4 checks passed
@teqdruid teqdruid deleted the teqdruid/esirt-dist2 branch May 14, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ESI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teqdruid
0