8000 [SV] Add UnpackedArrayCreateOp by uenoku · Pull Request #7303 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SV] Add UnpackedArrayCreateOp #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

[SV] Add UnpackedArrayCreateOp #7303

merged 1 commit into from
Jul 18, 2024

Conversation

uenoku
Copy link
Member
@uenoku uenoku commented Jul 11, 2024

This commit adds unpacked array create op that will be lowered into array literal
'{..}.

Since array literal must be used in assignment-like context,unpacked_array_create is always spilled to a temporary wire.

The operand ordering follows HW array representation. This is currently tricky since we emit unpacked types slightly differently (downTo) but the correct ordering is emitted in ExportVeriliog.

@uenoku
[SV] Add UnpackedArrayCreateOp
a5e1259 
This commit adds unpacked array create op that will be lowered into array literal
 `'{..}`.

Since array literal must be used in assignment-like context,`unpacked_array_create`
is always spilled to a temporary wire.

The operand ordering follows HW array representation. This is currently tricky since
we emit unpacked types slightly differently (`downTo`) but the correct ordering is emitted
in ExportVeriliog.
@uenoku uenoku requested a review from darthscsi as a code owner July 11, 2024 11:50
@uenoku uenoku mentioned this pull request Jul 11, 2024
Merged
fabianschuiki
fabianschuiki approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor
@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Having an op to explicitly construct unpacked arrays is going to help with lowering debug hierarchies to SV 👍

@uenoku uenoku merged commit f9b58a0 into main Jul 18, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/unpacked-array-create branch July 18, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uenoku @fabianschuiki
0