8000 [SMT] fix the declaration function name in ArrayBroadcastOp by Clo91eaf · Pull Request #8299 · llvm/circt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SMT] fix the declaration function name in ArrayBroadcastOp #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

[SMT] fix the declaration function name in ArrayBroadcastOp #8299

merged 1 commit into from
Apr 14, 2025

Conversation

Clo91eaf
Copy link
Contributor
@Clo91eaf Clo91eaf commented Mar 5, 2025

Fixed a minor issue in the SMT description. The SMT dialect does not have an smt.declare operation. It should be smt.declare_fun.

@Clo91eaf Clo91eaf requested a review from maerhart as a code owner March 5, 2025 02:30
@Clo91eaf Clo91eaf force-pushed the fix-smt-doc branch 2 times, most recently from 6eb12c9 to 2b5226f Compare March 5, 2025 02:34
maerhart
maerhart approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member
@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@Clo91eaf
[SMT] fix the operation name in ArrayBroadcastOp description
54376aa 
Signed-off-by: Clo91eaf <Clo91eaf@qq.com>
@SpriteOvO SpriteOvO merged commit 87f7feb into llvm:main Apr 14, 2025
5 checks passed
@makslevental
Copy link
Contributor

FYI this needs to be fixed here now https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/SMT/IR/SMTArrayOps.td#L78

@Clo91eaf
Copy link
Contributor Author

@makslevental Thank you for porting smt to mlir! I will upstream this typo fix pr to llvm later.

@Clo91eaf Clo91eaf deleted the fix-smt-doc branch April 15, 2025 00:37
@Clo91eaf Clo91eaf mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maerhart maerhart maerhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Clo91eaf @makslevental @maerhart @SpriteOvO
0