[MLIR][Presburger] removeTrivialRedundancy: skip unnecessary redundancy check #138969
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir-presburger @llvm/pr-subscribers-mlir Author: Leonid Gorbunov (leontyumen) Changes"removeTrivialRedundancy" marks duplicated rows before it unites constraints that differ only in the constant term. So it is clear that the first part is unnecessary. I removed it. Full diff: https://github.com/llvm/llvm-project/pull/138969.diff 1 Files Affected:
diff --git a/mlir/lib/Analysis/Presburger/IntegerRelation.cpp b/mlir/lib/Analysis/Presburger/IntegerRelation.cpp
index 097cb9c2201aa..790a0f60e6fd8 100644
--- a/mlir/lib/Analysis/Presburger/IntegerRelation.cpp
+++ b/mlir/lib/Analysis/Presburger/IntegerRelation.cpp
@@ -21,7 +21,6 @@
#include "mlir/Analysis/Presburger/Simplex.h"
#include "mlir/Analysis/Presburger/Utils.h"
#include "llvm/ADT/DenseMap.h"
-#include "llvm/ADT/DenseSet.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/Sequence.h"
#include "llvm/ADT/SmallBitVector.h"
@@ -45,7 +44,6 @@ using namespace mlir;
using namespace presburger;
using llvm::SmallDenseMap;
-using llvm::SmallDenseSet;
std::unique_ptr<IntegerRelation> IntegerRelation::clone() const {
return std::make_unique<IntegerRelation>(*this);
@@ -1824,8 +1822,6 @@ void IntegerRelation::removeTrivialRedundancy() {
// for a given row.
SmallDenseMap<ArrayRef<DynamicAPInt>, std::pair<unsigned, DynamicAPInt>>
rowsWithoutConstTerm;
- // To unique rows.
- SmallDenseSet<ArrayRef<DynamicAPInt>, 8> rowSet;
// Check if constraint is of the form <non-negative-constant> >= 0.
auto isTriviallyValid = [&](unsigned r) -> bool {
@@ -1840,8 +1836,7 @@ void IntegerRelation::removeTrivialRedundancy() {
SmallVector<bool, 256> redunIneq(getNumInequalities(), false);
for (unsigned r = 0, e = getNumInequalities(); r < e; r++) {
DynamicAPInt *rowStart = &inequalities(r, 0);
- auto row = ArrayRef<DynamicAPInt>(rowStart, getNumCols());
- if (isTriviallyValid(r) || !rowSet.insert(row).second) {
+ if (isTriviallyValid(r)) {
redunIneq[r] = true;
continue;
}
|
|
Failure in flang seems unrelated. |
|
@leontyumen Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
…r duplicate constraints (llvm#138969) `removeTrivialRedundancy` first marks duplicate rows redundant, then when multiple rows differ only by a constant term, it removes all but one of them. Since the latter removes all but one duplicate row as well, it is unnecessary (redundant!) to mark duplicate rows redundant. So we remove this step.
removeTrivialRedundancyfirst marks duplicate rows redundant, then when multiple rows differ only by a constant term, it removes all but one of them. Since the latter removes all but one duplicate row as well, it is unnecessary (redundant!) to mark duplicate rows redundant. So we remove this step.