[Support] Use std::map::try_emplace (NFC) #141374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try_emplace can default-construct values, so we do not need to do so on our own.
|
@llvm/pr-subscribers-llvm-support Author: Kazu Hirata (kazutakahirata) Changestry_emplace can default-construct values, so we do not need to do so Full diff: https://github.com/llvm/llvm-project/pull/141374.diff 1 Files Affected:
diff --git a/llvm/lib/Support/DAGDeltaAlgorithm.cpp b/llvm/lib/Support/DAGDeltaAlgorithm.cpp
index 48302b8cb0621..981536473d124 100644
--- a/llvm/lib/Support/DAGDeltaAlgorithm.cpp
+++ b/llvm/lib/Support/DAGDeltaAlgorithm.cpp
@@ -179,8 +179,8 @@ DAGDeltaAlgorithmImpl::DAGDeltaAlgorithmImpl(
const std::vector<edge_ty> &Dependencies)
: DDA(DDA) {
for (change_ty Change : Changes) {
- Predecessors.insert(std::make_pair(Change, std::vector<change_ty>()));
- Successors.insert(std::make_pair(Change, std::vector<change_ty>()));
+ Predecessors.try_emplace(Change);
+ Successors.try_emplace(Change);
}
for (const edge_ty &Dep : Dependencies) {
Predecessors[Dep.second].push_back(Dep.first);
@@ -210,7 +210,7 @@ DAGDeltaAlgorithmImpl::DAGDeltaAlgorithmImpl(
// Invert to form the predecessor closure map.
for (change_ty Change : Changes)
- PredClosure.insert(std::make_pair(Change, std::set<change_ty>()));
+ PredClosure.try_emplace(Change);
for (change_ty Change : Changes)
for (succ_closure_iterator_ty it2 = succ_closure_begin(Change),
ie2 = succ_closure_end(Change);
|
tgymnich
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try_emplace can default-construct values, so we do not need to do so
on our own.