AMDGPU: Fix broken XFAILed test for fat pointer null initializers #142015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesThis was failing on the buffer fat pointer lowering error in the Full diff: https://github.com/llvm/llvm-project/pull/142015.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll b/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll
index 6556f07c73504..e039225dba3e7 100644
--- a/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll
+++ b/llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll
@@ -1,6 +1,6 @@
; XFAIL: *
-; RUN: llc < %s -mtriple=amdgcn-- -verify-machineinstrs | FileCheck -check-prefixes=CHECK,GCN %s
-; RUN: llc < %s -mtriple=r600-- -verify-machineinstrs | FileCheck -check-prefixes=CHECK,R600 %s
+; REQUIRES: asserts
+; RUN: llc -mtriple=amdgcn-- < %s
; This is a temporary xfail, as the assembly printer is broken when dealing with
; lowerConstant() trying to return a value of size greater than 8 bytes.
@@ -9,10 +9,10 @@
; The exact form of the GCN output depends on how the printer gets fixed.
; GCN-NEXT: .zeroes 5
; R600-NEXT: .long 0
-@nullptr7 = global ptr addrspace(7) addrspacecast (ptr null to ptr addrspace(7))
+; @nullptr7 = global ptr addrspace(7) addrspacecast (ptr null to ptr addrspace(7))
; CHECK-LABEL: nullptr8:
; The exact form of the GCN output depends on how the printer gets fixed.
; GCN-NEXT: .zeroes 4
; R600-NEXT: .long 0
-@nullptr8 = global ptr addrspace(8) addrspacecast (ptr null to ptr addrspace(7))
+@nullptr8 = global ptr addrspace(8) addrspacecast (ptr null to ptr addrspace(8))
|
krzysz00
approved these changes
May 29, 2025
30a7806 to
77d99f4
Compare
Base automatically changed from
users/arsenm/amdgpu/start-using-context-errors-buffer-fat-pointer-lowering
to
main
May 30, 2025 05:52
This was failing on the buffer fat pointer lowering error in the addrspace(7) case, not the expected asm printer breakage. Also remove the attempt at FileChecking the result, since that is dependent on the actual fix and we want the unexpected pass whenever the assert is fixed.
53f7285 to
752f017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing on the buffer fat pointer lowering error in the
addrspace(7) case, not the expected asm printer breakage. Also remove
the attempt at FileChecking the result, since that is dependent on the
actual fix and we want the unexpected pass whenever the assert is fixed.