8000 Set policy CMP0167 to avoid warnings with CMake 3.30 by jorisv · Pull Request #3 · lmontaut/coal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set policy CMP0167 to avoid warnings with CMake 3.30 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: topic/coal
Choose a base branch
from
Open

Set policy CMP0167 to avoid warnings with CMake 3.30 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
774b32a
cmake: Set policy CMP0167 to avoid warnings with CMake 3.30
jorisv Jul 24, 2024
db45be6
changelog: Add changelog entry
jorisv Jul 24, 2024
23b3a0b
ci: debug
jorisv Jul 24, 2024
cbf1ee9
ci: Remove ccache to debug
jorisv Jul 26, 2024
1bf9e14
ci: Add cxx-compiler to Windows build
jorisv Jul 26, 2024
9b3741d
ci: Don't call vcvarsall.bat
jorisv Jul 26, 2024
47f046a
cmake: Revert policy change to debug
jorisv Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/conda/environment_windows.yml
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ dependencies:
- qhull
- cmake
- ccache
- cxx-compiler
- pkg-config
- ninja
5 changes: 2 additions & 3 deletions .github/workflows/windows-conda-clang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Build Coal
shell: cmd /C CALL {0}
run: |
call "%programfiles(x86)%\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" amd64
call conda list
:: Tell Ninja to use clang-cl
set CC=clang-cl
set CXX=clang-cl
Expand All @@ -54,7 +54,6 @@ jobs:
cmake ^
-G "Ninja" ^
-DCMAKE_INSTALL_PREFIX=%CONDA_PREFIX%\Library ^
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache ^
-DCMAKE_BUILD_TYPE=Release ^
-DGENERATE_PYTHON_STUBS=ON ^
-DPYTHON_SITELIB=%CONDA_PREFIX%\Lib\site-packages ^
Expand All @@ -65,7 +64,7 @@ jobs:
if errorlevel 1 exit 1

:: Build and Install
cmake --build . --config Release --target install
ninja install -v
if errorlevel 1 exit 1

:: Testing
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/windows-conda-v142.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Build Coal
shell: cmd /C CALL {0}
run: |
call "%programfiles(x86)%\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" amd64
call conda list

:: Create build
mkdir build
Expand All @@ -62,7 +62,7 @@ jobs:
if errorlevel 1 exit 1

:: Build and Install
cmake --build . --config Release --target install
ninja install -v
if errorlevel 1 exit 1

:: Testing
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Fix issue in Octomap.computeLocalAABB
- Fix unsupported function for contact_patch_matrix
- Fix Octomap dependency on ROS
- Remove CMake CMP0167 warnings

## [2.4.4] - 2024-03-06

Expand Down
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ else()
endif()
endif()


# Use BoostConfig module distributed by boost library instead of using FindBoost module distributed
# by CMake
# if(POLICY CMP0167)
# cmake_policy(SET CMP0167 NEW)
# endif()
include("${JRL_CMAKE_MODULES}/boost.cmake")
include("${JRL_CMAKE_MODULES}/python.cmake")
include("${JRL_CMAKE_MODULES}/hpp.cmake")
Expand Down
Loading
0