Update doc parsing #324
Merged
Update doc parsing #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -349,9 +350,25 @@ export class FilesNamespace { | |||
| * | |||
| * @deprecated Document parsing API is still in active development. Stay tuned for updates. | |||
| */ | |||
| public async parseDocument(fileHandle: FileHandle, stack?: string) { | |||
| public async parseDocument(fileHandle: FileHandle, parseOpts?: DocumentParsingOpts) { | |||
There was a problem hiding this comment.
You can provide defaults like so.
public async parseDocument(fileHandle: FileHandle, parseOpts: DocumentParsingOpts = {}) {
| public async parseDocument(fileHandle: FileHandle, stack?: string) { | ||
| public async parseDocument(fileHandle: FileHandle, parseOpts?: DocumentParsingOpts) { | ||
| const stack = getCurrentStack(1); | ||
| const parseOptsObj: DocumentParsingOpts = parseOpts || {}; |
There was a problem hiding this comment.
^ Use the default pattern like above
| * | ||
| * @deprecated Document parsing API is still in active development. Stay tuned for updates. | ||
| */ | ||
| public async documentParserId(fileHandle: FileHandle) { |
There was a problem hiding this comment.
Maybe "getDocumentParsingMethod"?
There was a problem hiding this comment.
Not in love with Method here. Can we do getDocumentParsingLibrary or getDocumentParsingBackend or getDocumentParsingFramework
There was a problem hiding this comment.
Switched to getDocumentParsingLibrary
|
|
||
| /** | ||
| * @deprecated | ||
| * N.B.: onProgress returns progress as a float taking values from 0 to 1, 1 being completed |
There was a problem hiding this comment.
This comment doesn't seem to belong here.
91D6
ryan-the-crayon
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.