8000 The presence of '<unk>' token wasn't checked correctly by varisd · Pull Request #3 · lmthang/bivec · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

The presence of '<unk>' token wasn't checked correctly #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The presence of '<unk>' token wasn't checked correctly #3

wants to merge 1 commit into from

Conversation

varisd
Copy link
@varisd varisd commented Oct 27, 2017

Using only GetWordHash(unk_word) to check whether the '' token is included in the vocabulary can fail if there was other token with the same hash.
Using SearchVocab() function instead solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@varisd
0