Allow custom text and icon for Keycloak #3181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3181 +/- ##
==========================================
+ Coverage 60.37% 60.41% +0.04%
==========================================
Files 105 105
Lines 13668 13670 +2
==========================================
+ Hits 8252 8259 +7
+ Misses 5416 5411 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
motorina0
reviewed
May 30, 2025
| @@ -665,7 +667,9 @@ window.app.component('username-password', { | |||
| return this.oauth.some(m => this.authMethods.includes(m)) | |||
| } | |||
| }, | |||
| created() {} | |||
| created() { | |||
| console.log(this.keycloakIcon) | |||
motorina0
reviewed
May 30, 2025
| @@ -316,7 +316,7 @@ window.localisation.en = { | |||
| signin_with_nostr: 'Continue with Nostr', | |||
| signin_with_google: 'Sign in with Google', | |||
| signin_with_github: 'Sign in with GitHub', | |||
| signin_with_keycloak: 'Sign in with Keycloak', | |||
| signin_with_keycloak: 'Sign in with {custom_org}', | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| signin_with_keycloak: 'Sign in with {custom_org}', | |
| signin_with_custom_org: 'Sign in with {custom_org}', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign in with {Keycloak or custom org}Closes #2899