-
Notifications
You must be signed in to change notification settings - Fork 147
feat(LUD-16): support for multiple identifiers #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae52c57
to
2b9a7c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition
+1 - we actually added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
< 8000 /form>I like this.
Although this is a breaking change as current LUD-16 implementers would not accept Lightning Addresses with a tag.
You are perfectly right, however, as described in #197:
So in practice this should not lead to any problems on the It is a different story on the
In practice, some wallets do not validate the address and just perform the What do you think? |
i think current implementation would just see it as new address and would probably just throw a 404 or similar, but that is on the user to not use the tag on an unsupporting service. its also simple for the user to test if a service supports it, just try fetching an invoice with that address + tag. |
Ack. This is good 👍 |
@theborakompanioni Yes, I was mostly concerned about Anyway I don't think this is a big deal. I'm for merging this one. |
How do I start creating my own codes |
The idea is that you should be able to append whatever you like to your existing lightning address. They do not really exist and are "created on the fly" when people use them. |
Implementing this in ZBD side asap |
Resolves #197.
Adds support for
+<tag>
when paying to static internet identifiers.