8000 Removes localgov_content_lock and localgov_login_redirect from the profile. by rupertj · Pull Request #807 · localgovdrupal/localgov · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removes localgov_content_lock and localgov_login_redirect from the profile. #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

Removes localgov_content_lock and localgov_login_redirect from the profile. #807

merged 2 commits into from
Jan 22, 2025

Conversation

rupertj
Copy link
Member
@rupertj rupertj commented Jan 14, 2025 •
edited
Loading

Fix #778

@rupertj
Removes localgov_content_lock and localgov_login_redirect from the pr…
e5f3922 
…ofile so we can use the spun-out versions. Updates composer.json and localgov.info.yml.
@rupertj rupertj requested a review from millnut January 14, 2025 12:19
finnlewis
finnlewis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member
@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it just works! Nice one @rupertj !

As an aside: I note that we do not enable the content_lock functionality by default, I wonder if we might want to do this? (in a another issue).

@ekes
Copy link
Member
ekes commented Jan 21, 2025

Tested with a clean current install, with php caching on for the autoloader, and updated:

drush cr after update works with this one 😅

But it does require a cache rebuild after update.

@finnlewis
Copy link
Member

Thanks @ekes ! I'll merge and tag a release.

@finnlewis finnlewis merged commit 729aecc into 3.x Jan 22, 2025
11 checks passed
@finnlewis finnlewis deleted the fix/3.x/778-remove-submodules branch January 22, 2025 13:13
andybroomfield pushed a commit that referenced this pull request Jan 28, 2025
@finnlewis @millnut @rupertj
3.0.14 release (#810)
273381f 
* feat: update gin to recommended version (#808)

* feat: update gin to recommended version

* feat: update gin to recommended version

* Removes localgov_content_lock and localgov_login_redirect from the profile so we can use the spun-out versions. Updates composer.json and localgov.info.yml. (#807)

Co-authored-by: Finn Lewis <finn@opencode.uk>

* Remove dependency on search_api. (#812)

---------

Co-authored-by: Lee <8024370+millnut@users.noreply.github.com>
Co-authored-by: Rupert Jabelman <rupert@jabelman.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

@millnut millnut Awaiting requested review from millnut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull submodules localgov_content_lock and localgov_login_redirect out of the profile
3 participants
@rupertj @ekes @finnlewis
0