8000 Disable HTML5 form validation by default #503 by ekes · Pull Request #820 · localgovdrupal/localgov · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disable HTML5 form validation by default #503 #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

Disable HTML5 form validation by default #503 #820

merged 4 commits into from
Feb 25, 2025

Conversation

ekes
Copy link
Member
@ekes ekes commented Feb 4, 2025

@ekes ekes requested a review from millnut February 4, 2025 13:31
@ekes
Copy link
Member Author
ekes commented Feb 4, 2025 •
edited
Loading

Am I correct that it's failing to install disable_html5_validation because it requires D10, but states Drupal: >=9 Is this the automagically created composer.json file from Drupal.org maybe? (It doesn't seem to have one)

@millnut
Copy link
Member
millnut commented Feb 5, 2025

Hi @ekes I believe it's because localgov doesn't yet have D11 support so it's failing the D11 install because of this line, and as the branch was created from 3.x it only has D10 support currently

@ekes
Copy link
Member Author
ekes commented Feb 11, 2025

@millnut So we won't be able to get the tests to pass for D10?

@finnlewis
Copy link
Member

Passing to @millnut to try to get the tests running for D10 at least!

@millnut
Copy link
Member
millnut commented Feb 11, 2025

@finnlewis @ekes I've temporarily disabled the needs check for the phpunit step so it will continue even if the build fails so we can see the phpunit tests for D10.

This error/issue will go away once the other modules have D11 support, and we can then declare the profile as working with D11

@finnlewis finnlewis mentioned this pull request Feb 18, 2025
Closed
@stephen-cox
Copy link
Member

I've updated the workflow so it only tests against D10 for now. We'll need to revert this once the profile can declare D11 support.

ekes
ekes commented Feb 25, 2025
View reviewed changes
Copy link
Member Author
@ekes ekes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping testing against 11.x till we want to test it seems fine to me.

MR itself is simple enough and agreed.

Ah! And I can't approve this because I created the original MR!

finnlewis
finnlewis approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member
@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks folks, let's get this in,

@finnlewis finnlewis merged commit 88e2b84 into 3.x Feb 25, 2025
12 of 13 checks passed
@finnlewis finnlewis deleted the feature/default-html5-validation-off branch February 25, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

@millnut millnut Awaiting requested review from millnut

@stephen-cox stephen-cox Awaiting requested review from stephen-cox

@andybroomfield andybroomfield Awaiting requested review from andybroomfield

Assignees

@millnut millnut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekes @millnut @finnlewis @stephen-cox
0