8000 fix: missing prev-next attributes for nav by millnut · Pull Request #797 · localgovdrupal/localgov_base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: missing prev-next attributes for nav #797< 8000 /span>

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

millnut
Copy link
Member
@millnut millnut commented May 30, 2025

What does this change?

Recent changes in prev-next have broken tests, see https://github.com/localgovdrupal/localgov/actions/runs/15327716159/job/43126523978

This is because the classes are missing on the <nav> element

With this PR it reinstates these to look like (publications as an example);

<nav class="lgd-prev-next lgd-prev-next--publications">

Currently these classes are missing and this is shown

<nav>

@millnut millnut requested a review from markconroy May 30, 2025 14:57
@finnlewis
Copy link
Member
finnlewis commented Jun 3, 2025

Thanks @millnut - any idea why the workflow is not running?

@msayoung msayoung self-requested a review June 3, 2025 11:15
Merge 2.x back to feature branch
@millnut
Copy link
Member Author
millnut commented Jun 3, 2025

Thanks @millnut - any idea why the workflow is not running?

Because of this #799 would be my guess, looks like they are running now

@finnlewis finnlewis merged commit 0af6f46 into 2.x Jun 10, 2025
27 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0