2.13.6 #238
Merged
2.13.6 #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- adds admin role module
* adds admin role module * adds admin to roleshelper * adds dependency on localgov_roles --------- Co-authored-by: ekes <ekes@iskra.net>
markconroy
approved these changes
Aug 5, 2024
* adds revisions compare button to top of form * coding standards fix * sets the top revisions compare button to sticky --------- Co-authored-by: ekes <ekes@iskra.net>
* Initial commit. * Added test for block placement. Fixed various issues. * Injected dependencies properly. * Code style * Code style. * Sanitises block IDs, as we derive it from the plugin name, which can contain characters like : which aren't allowed in config IDs. * Code style. * Changed DefaultBlockInstaller::sanitiseId() to work like Drupal\Core\Block\BlockPluginTrait::getMachineNameSuggestion(). * Adds ability to disable default block installation via config * Documented how to turn off block placement. * Fixed misleading comment. * Fix typo in README. * Allowed default blocks to be placed when a site is installed. * Added special case for when the active theme comes back as 'core'. * Code style. * Better docs. Implemented hook_localgov_post_install() to fix the issue with installing blocks in in the installer. Moved the configuration that prevents the installation of default blocks inside the service class. * Moved how test fixture module is installed in DefaultBlockTest::testBlockDisplay(). * Revert change to test. Fix backwards logic when checking if we're in the installer.
|
Looks like we're still failing the static analysis checks: https://github.com/localgovdrupal/localgov_core/actions/runs/10265629608/job/28402307715?pr=238 |
|
@ekes might have time to fix the static analysis checks. |
|
@ekes - might this be quick? |
…s-installed Do not call assignModuleRoles during config import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.