adds documents to linkit profile #254
Conversation
|
Sounds like we need a bit of testing. Also: some councils are using less ckeditor embedded buttons and are using paragraphs more. |
|
What is the expected behaviour of a LinkIt link to a document? Is it: a) to the canonical url of the media item (/media/123) |
|
I think this is with @willguv to check with content people. |
|
Discussing this again at Merge Tuesday - need to understand the tech complexities - will create a Slack chat on this. |
|
@willguv have you had a chance to chat about this one with content people yet? Thanks dude! |
|
Hi @finnlewis not yet sorry - thanks for the nudge Can we describe in content designer language what this PR describes? Or can we spend a bit of our session next Monday looking at it/ writing something? |
|
Discussing this with @willguv , this is part of a bigger review about how we want to guide people on best practice for displaying documents. Converting to draft for now. |
|
@finnlewis @ekes I'd like to make some progress on this before the 24th April newsletter if possible @benhillsjones asked for:
I think @markconroy's PR does this, and there's three questions outstanding:
a) to the canonical url of the media item (/media/123) I haven't received specific feedback from content folks, but think b) is expected. A user will see the kind of file they're downloading
Would be great to get your thoughts on these Qs and anything else. Thanks |
I assume this should work. But it means you need to make it so you replace that original file (that filename at that path) if there are any changes to it. This isn't default Drupal behaviour, but I'd guess it can be made to do so. I don't think I've looked into how yet, mind. |
|
Or upload a new media item and re-do the link? @ekes I think that's how Wordpress behaves |
If you've remembered where the links are; and no one has saved the old direct link (including Google etc). |
|
Moving @finnlewis' comment from #253
So how about this approach @finnlewis @ekes?
Is this a big change from @markconroy's PR? Thanks all. |
|
Let's do a design sprint/ afternoon in May |
|
Re changes to file names with new versions - at Essex in the LGD implementation we blocked search engines from crawling documents, because I was fed up of answering requests to take down outdated documents from Google search. We did this in nginx but you could do the same in HTML with an Wouldn't solve the issue of people saving old links, but could be worth considering. Using the canonical media URL makes sense but I'd be curious to see search engine behaviour in this case (e.g. is it a temporary or permanent redirect) |
|
We're looking to arrange a mini sprint on this, 2 hours co-working. Suggesting at least the following: @Adnan-cds @ekes @markconroy @willguv @finnlewis @NikLP @stephen-cox @willguv suggesting 09:30 -11:30 on 8th May. We also have the general question of how to present documents that are attached to pages, including how to specify the 'name' of the file. https://demo.localgovdrupal.org/test-subsite-demo-all-components/test-pages-documents |
|
@finnlewis Would it be wise to rope in someone with enhanced accessibility/usability chops? Seemed like Dan C had a good amount of sane things to say when we brought this matter up in tech drop-in a couple of weeks ago. Presumably Maria is another viable option. |
|
Adding a doc via the 'Insert Media' button gives this type of url /url-string/file-name.pdf eg https://demo.localgovdrupal.org/sites/default/files/2025-05/Eastbourne%20BLF14%20invitation.pdf See bottom of https://demo.localgovdrupal.org/adult-health-and-social-care/support-your-home/home-monitoring-and-personal-alarms for example |
|
Discussing this in our mini-sprint:
Those present seem to mostly be in accord that we should change the linkit behaviour to link to the file, for consistency with the existing media embed behaviour. We will then create separate issues for
|
…dia/123 canonical.
Closes #253
What does this change?
How to test
Try to link to a document in a wysiwyg, you should see "Document: [media - name]" for available documents in your linkit suggestions.
Have we considered potential risks?
I'm not fully sure what happens when a document is changed/gets a new file.
Thanks to Big Blue Door for sponsoring my time to work on this.