feat: upgrade field_group to version 4 #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnlewis
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Tested this locally along with the other related pull requests, using:
composer require "localgovdrupal/localgov_news:dev-feature/2.x/upgrade-fieldgroup-to-v4 as 2.4.1" "localgovdrupal/localgov_paragraphs:dev-feature/2.x/upgrade-fieldgroup-to-v4 as 2.5.5 " "localgovdrupal/localgov_services:dev-feature/2.x/upgrade-fieldgroup-to-v4 as 2.1.18" "localgovdrupal/localgov_core:dev-feature/2.x/upgrade-fieldgroup-to-v4 as 2.14.3" -W
All seems to work just fine!
|
@millnut also removed the patch on field_group, merged a while ago https://git.drupalcode.org/project/field_group/-/merge_requests/85#note_502503 released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This upgrades field_group to v4, this brings UX bug fixes and some general bug fixes.
The maintainer says this about v4;
So should be safe to bump the version.
field_group v3 is due to be marked as unsupported soon see https://www.drupal.org/project/field_group/issues/3520770#comment-16083966
How to test
Testing will mean also updating to the following modules which also have PRs for field_group v4