8000 With the view "files" disabled, localgov_core cause an exception #283 by ekes · Pull Request #297 · localgovdrupal/localgov_core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

With the view "files" disabled, localgov_core cause an exception #283 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2025
Merged

With the view "files" disabled, localgov_core cause an exception #283 #297

merged 6 commits into from
May 27, 2025

Conversation

ekes
Copy link
Member
@ekes ekes commented May 13, 2025

Push of further developed branch from #283

marcopagliarulo and others added 4 commits April 8, 2025 22:18
@marcopagliarulo
With the view "files" disabled, localgov_core cause an exception
58ee468
@marcopagliarulo
With the view "files" disabled, localgov_core cause an exception - co…
66dc592 
…mment empty catch
@ekes
The intention of #221 was to move the files tab from the main content…
14697a9 
… menu.

Note: This is opinionated administration configuration that probably
shouldn't be enforced on users just requiring core or media. It probably
wants to live somewhere else.
@ekes
Link to the files view under media. As per #221. See also #283 issues.
32c098a 
The view is supplied by localgov_media so creating the link here too.
Probably wants to be in some other LocalGov Admin configuration module
really.
@ekes
Copy link
Member Author
ekes commented May 13, 2025

Still needs a simple test to check:
a) Default menu item is not present
b) Our menu item is present
c) It does not break when you delete the view.

@ekes
Copy link
Member Author
ekes commented May 13, 2025

Still needs a simple test to check:

HA! "simple"

We don't yet have tests for this.
Writing a test I don't get the optional config view (views.view.files) overridden.
We should confirm the view gets overridden in which circumstances?
The view (and menu) should be overwritten by a different module (not core or media) - probably something to do with 'Admin customisations'.

Suggest, merge this and make a follow-up? @finnlewis @stephen-cox @tonypaulbarker

This was referenced May 15, 2025
Closed
Merged
@ekes ekes requested a review from finnlewis May 15, 2025 14:32
@finnlewis
Copy link
Member

Also see the source of the original pull request #221

@stephen-cox stephen-cox self-requested a review May 20, 2025 11:16
stephen-cox
stephen-cox approved these changes May 23, 2025
View reviewed changes
Copy link
Member
@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

A follow up issue for tests sounds good.

@stephen-cox
Copy link
Member

We do need to fix the coding standards failure before merging

FILE: ...lgov_core/modules/localgov_media/src/Plugin/Derivative/FilesLocalTasks.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------

@stephen-cox
Copy link
Member

We do need to fix the coding standards failure before merging

FILE: ...lgov_core/modules/localgov_media/src/Plugin/Derivative/FilesLocalTasks.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------

I have fixed it 🙂

@finnlewis finnlewis merged commit 0d21e01 into 2.x May 27, 2025
17 checks passed
@finnlewis finnlewis mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-cox stephen-cox stephen-cox approved these changes

@finnlewis finnlewis Awaiting requested review from finnlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekes @finnlewis @stephen-cox @marcopagliarulo
0