Media module container_rebuild_required key for D11.2 #308
Conversation
|
@tonypaulbarker can this come out of draft and get included in a release so I can run a full D11.2 test |
|
@millnut @stephen-cox some good news, this does appar to nudge us along. I've marked it ready for review. Until this is reviewed and merged I think a command li
8000
ke this can be used for testing: I had to take a few additional steps noted here: Mariadb in ddev to 10.6 localgovdrupal/localgov_project#197 I saw the permissions error that this may fix localgovdrupal/localgov_project#197 Also to note that for me Drupal 10.5 did not complain about the new key. |
|
Hi @tonypaulbarker yep those changes (mariadb, paratest, etc...) are already in the 3.2.x branch of the project which contains all the other Drupal 11.x work |
|
@tonypaulbarker I tried adding Locally, I edited all the info.yml files to add the new key and then ran the test in the localgov_homepage_paragraphs module. It still fails with a missing dependency on media.type.image. The config for this is in localgov_media and moving it from optional to install fixes the test. |
|
Thanks for the information @stephen-cox . Having analysed some more I think media dependencies are doing the trick on a 'full' install but the unit test requires some limited things in isolation at the moment so fails. Only moving 'types' might get those tests to pass but moving everything out of optional is probably the right move because in practice the optional dependencies are always satisfied. |
What does this change?
Fixes #307
Introduces container_rebuild_required key for the media module for 11.2+ support
How to test
Tests should no longer complain about the media config, e.g. Drupal 11 test failures localgov_paragraphs#247
The project should install on 11.2
Should not be regressions when installing for older versions of Drupal
How can we measure success?
We can move closer to Drupal 11.2 support.
Have we considered potential risks?
The key breaks something in older versions
We enter a game of 'whack-a-mole' where we move on just one step and see another failure.