8000 Fix JVM startup for StepFunctions by MEPalma · Pull Request #11910 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix JVM startup for StepFunctions #11910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix JVM startup for StepFunctions #11910

merged 1 commit into from
Nov 22, 2024

Conversation

MEPalma
Copy link
Contributor
@MEPalma MEPalma commented Nov 22, 2024 •
edited by dominikschubert
Loading

Motivation

Started seeing issues regarding JVM in the latest container:

...
    instance.set(factory())
                 ^^^^^^^^^
  File "/opt/code/localstack/localstack-core/localstack/services/stepfunctions/asl/jsonata/jsonata.py", line 64, in get
    return _JSONataJVMBridge()
           ^^^^^^^^^^^^^^^^^^^
  File "/opt/code/localstack/localstack-core/localstack/services/stepfunctions/asl/jsonata/jsonata.py", line 50, in __init__
    jvm_path = jpype.getDefaultJVMPath()
               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/code/localstack/.venv/lib/python3.11/site-packages/jpype/_jvmfinder.py", line 70, in getDefaultJVMPath
    return finder.get_jvm_path()
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/code/localstack/.venv/lib/python3.11/site-packages/jpype/_jvmfinder.py", line 204, in get_jvm_path
    raise JVMNotFoundException("No JVM shared library file ({0}) "

This PR fixes this by pointing JPype to the correct JVM path

@MEPalma MEPalma added the semver: patch Non-breaking changes which can be included in patch releases label Nov 22, 2024
@MEPalma MEPalma self-assigned this Nov 22, 2024
@dominikschubert dominikschubert marked this pull request as ready for review November 22, 2024 19:05
dominikschubert
dominikschubert approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested by manually patching the container and running tests against it after restarting

@dominikschubert dominikschubert changed the title StepFunctions, JVM start Fix JVM startup for StepFunctions Nov 22, 2024
@dominikschubert dominikschubert merged commit 32fb0e0 into master Nov 22, 2024
27 of 38 checks passed
@dominikschubert dominikschubert deleted the MEP-sfn-jvmstart branch November 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@MEPalma MEPalma

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @dominikschubert
0