8000 Remove custom spec for AWS StepFunctions by dominikschubert · Pull Request #11925 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove custom spec for AWS StepFunctions #11925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

Remove custom spec for AWS StepFunctions #11925

merged 1 commit into from
Nov 26, 2024

Conversation

dominikschubert
Copy link
Member

Motivation

With 907c3b1 we added a custom spec for the StepFunctions API to make sure 2 things happen:

  1. ASF has a spec to use for serializing response objects
  2. AWS clients used in our tests can de-serialize the response into proper boto3 response objects

With the most recent botocore update in #11918 , this isn't necessary anymore as it now already includes the newest changes to the StepFunctions API.

Changes

  • Removes the custom spec file for StepFunctions. With the recently updated botocore spec, this is basically a NO-OP.

@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Nov 25, 2024
@dominikschubert dominikschubert self-assigned this Nov 25, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 53m 2s ⏱️ + 4m 0s
3 727 tests ±0  3 380 ✅ ±0  347 💤 ±0  0 ❌ ±0 
3 729 runs  ±0  3 380 ✅ ±0  349 💤 ±0  0 ❌ ±0 

Results for commit d48e5bb. ± Comparison against base commit 4ff3829.

@dominikschubert dominikschubert marked this pull request as ready for review November 26, 2024 05:47
alexrashed
alexrashed approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot for following up on this now that the new specs are contained in the new botocore package! 💯 🧹 🦸🏽

MEPalma
MEPalma approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor
@MEPalma MEPalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschubert dominikschubert merged commit 1abd2ff into master Nov 26, 2024
35 of 36 checks passed
@dominikschubert dominikschubert deleted the sfn-remove-custom-spec branch November 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@MEPalma MEPalma MEPalma approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @alexrashed @MEPalma
0