8000 Add analytics for event rule engine by joe4dev · Pull Request #11928 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add analytics for event rule engine #11928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add analytics for event rule engine #11928

merged 1 commit into from
Nov 27, 2024

Conversation

joe4dev
Copy link
Member
@joe4dev joe4dev commented Nov 26, 2024

Supersedes #11807

Motivation

We are missing analytics tracking for the event ruler and a plugins.py to make the package installable (if we decide to ship it). Currently, we don't see the need for shipping it as the Java-based event ruler is opt-in.

Changes

  • Add env var tracking for EVENT_RULE_ENGINE
  • Make event-ruler package installable (in case we need to ship it to unblock users facing dynamic installation issues)

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Nov 26, 2024
@joe4dev joe4dev added this to the 4.0.3 milestone Nov 26, 2024
@joe4dev joe4dev self-assigned this Nov 26, 2024
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   4m 11s ⏱️ -4s
433 tests ±0  381 ✅ ±0   52 💤 ±0  0 ❌ ±0 
866 runs  ±0  762 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit ebc4ed1. ± Comparison against base commit 3a32d76.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 49m 34s ⏱️ +48s
3 727 tests ±0  3 380 ✅ ±0  347 💤 ±0  0 ❌ ±0 
3 729 runs  ±0  3 380 ✅ ±0  349 💤 ±0  0 ❌ ±0 

Results for commit ebc4ed1. ± Comparison against base commit 3a32d76.

@joe4dev joe4dev marked this pull request as ready for review November 27, 2024 14:32
@dominikschubert dominikschubert self-requested a review November 27, 2024 16:26
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ideally not gonna be necessary though if we can phase out the java one 👍

@joe4dev joe4dev merged commit 0331d0e into master Nov 27, 2024
46 checks passed
@joe4dev joe4dev deleted the event-ruler-analytics branch November 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0