8000 DynamoDB: disable Scalable Vectors Extensions on arm64 by tiurin · Pull Request #12226 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DynamoDB: disable Scalable Vectors Extensions on arm64 #12226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

DynamoDB: disable Scalable Vectors Extensions on arm64 #12226

merged 3 commits into from
Feb 4, 2025

Conversation

tiurin
Copy link
Contributor
@tiurin tiurin commented Feb 4, 2025 •
edited
Loading

Motivation

Fixes #12054.

Previous fix was using a java command to check available VM options, and this command was crashing for exactly the same reason as the DynamoDB process.

Changes

Added -XX:UseSVE=0 to java VM options for all arm64 processors. This is a wide catch, possibly at the cost of the performance on processors where new SVE instructions are supported, but serves as a workaroun. Macs don't support SVE anyway which is probably the main use case for localstack running on ARM.

Testing

Tested manually on M4 and M3 instance. Non-Apple ARM is checked with integration tests, this is probably as far as we can test.

tiurin added 2 commits February 4, 2025 13:42
@tiurin
Run Java VM option check without UseSVE
8b45b3c 
VM option check is also a java call that crashes exactly like the dynamoDB process
@tiurin
Only run VM options check for ARM architecture
10e38bb 
-XX:UseSVE=0 is unrecognized option on amd64 and leads to check crashing.
@tiurin tiurin added platform: arm64/aarch64 Issues related to Apple Silicon semver: patch Non-breaking changes which can be included in patch releases aws:dynamodb Amazon DynamoDB labels Feb 4, 2025
@tiurin tiurin changed the title No sve dynamodb m4 DynamoDB: disable Scalable Vectors Extensions on arm64 Feb 4, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 4, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   28m 54s ⏱️ - 1h 21m 43s
1 106 tests  - 2 971  1 042 ✅  - 2 720  64 💤  - 251  0 ❌ ±0 
1 108 runs   - 2 971  1 042 ✅  - 2 720  66 💤  - 251  0 ❌ ±0 

Results for commit d10c436. ± Comparison against base commit fd3d900.

This pull request removes 2971 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@tiurin
Simplify check condition
d10c436 
If check required to be run with `-XX:UseSVE=0` then there is no point in it.
@tiurin tiurin requested a review from alexrashed February 4, 2025 15:32
alexrashed
alexrashed approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot for digging into this, and for testing this in specifically provisioned M4 cloud instances! 💯 🦸🏽
Thanks a lot also to @viren-nadkarni for the great upfront analysis and the first blind fix! It's a pity that this command also just fails with the same error! 😅
The pipeline with the ARM64 integration tests also looks 💚 🥳

@tiurin tiurin merged commit bfb17b7 into master Feb 4, 2025
41 checks passed
@tiurin tiurin deleted the no-sve-dynamodb-m4 branch February 4, 2025 15:44
@tiurin tiurin added this to the 4.1 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni left review comments

@alexrashed alexrashed 67B7 alexrashed approved these changes

@giograno giograno Awaiting requested review from giograno giograno is a code owner

Assignees
No one assigned
Labels
aws:dynamodb Amazon DynamoDB platform: arm64/aarch64 Issues related to Apple Silicon semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

bug: Dynamodb service has issue starting (JRE crush on M4 Pro)
3 participants
@tiurin @alexrashed @viren-nadkarni
0