8000 Fix failing lambda error reporting test by dfangl · Pull Request #12300 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix failing lambda error reporting test #12300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix failing lambda error reporting test #12300

merged 1 commit into from
Feb 24, 2025

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Feb 24, 2025

Motivation

With recent updates to public.ecr.aws/lambda/python:3.12 it seems AWS ships a newer Lambda RIC client with those images than they use in AWS.

This leads to a disparity between the stacktrace returned by aws, and the one in LS.

As the stack trace line numbers are not really important to get exactly right, for me that is a reasonable compromise for now (other option would be pinning the images).

For now I have skipped the stack trace check - we should check in the future to unskip it once AWS incorporates the changes in their environment as well.

Changes

  • Update the test to python 3.13 (sadly this also has the change, but it is good to keep anyway)
  • Skip snapshot verify on the stackTrace

@dfangl dfangl added this to the 4.2 milestone Feb 24, 2025
@dfangl dfangl self-assigned this Feb 24, 2025
@dfangl dfangl requested a review from alexrashed February 24, 2025 16:37
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Feb 24, 2025
joe4dev
joe4dev approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member
@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dfangl for unblocking this line change.

This unblocks #12002
/cc @gregfurman

💡 Transforming the line could be an alternative to guard against future similar changes, which circumvents setting our future selves a reminder to re-snapshot this :)

@dfangl
Copy link
Member Author
dfangl commented Feb 24, 2025

I agree with transforming - I decided against it for two reasons:

  1. Theoretically the test is correct, we do break parity, and we are not doing it on purpose. So I feel a transformer is not the right choice.
  2. I want to unblock the pipeline quickly, and transforming might take a minute longer ;)

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 29m 4s ⏱️ - 24m 22s
3 109 tests  - 994  2 888 ✅  - 881  221 💤  - 112  0 ❌  - 1 
3 111 runs   - 994  2 888 ✅  - 881  223 💤  - 112  0 ❌  - 1 

Results for commit bbd1820. ± Comparison against base commit 8b5cedd.

This pull request removes 994 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@dfangl dfangl merged commit f5b247b into master Feb 24, 2025
34 checks passed
@dfangl dfangl deleted the lambda/fix-runtime-error-test branch February 24, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

@alexrashed alexrashed Awaiting requested review from alexrashed

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @joe4dev
0