8000 [ESM] Correctly enable exponential backoff inside stream poller by gregfurman · Pull Request #12312 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ESM] Correctly enable exponential backoff inside stream poller #12312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[ESM] Correctly enable exponential backoff inside stream poller #12312

merged 1 commit into from
Mar 7, 2025

Conversation

gregfurman
Copy link
Contributor

Motivation

A follow-up PR to #12281 that correctly initialises the exponential backoff object.

Changes

  • Fixes incorrectly passing the attempt counter to the boff object. Instead, the MaximumRetryAttempts attribute of the ESM config is used.

@gregfurman gregfurman added type: bug Bug report semver: patch Non-breaking changes which can be included in patch releases aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) labels Feb 27, 2025
@gregfurman gregfurman added this to the 4.3 milestone Feb 27, 2025
@gregfurman gregfurman self-assigned this Feb 27, 2025
@dfangl
Copy link
Member
dfangl commented Feb 27, 2025

I would classify this as a "minor" change, since it effectively activates the changes in #12281, which was also minor.
8000

@gregfurman gregfurman added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: patch Non-breaking changes which can be included in patch releases labels Feb 27, 2025
@localstack-bot
Copy link
Collaborator

Currently, only patch changes are allowed on master. Your PR labels (type: bug, semver: minor, aws:lambda:event-source-mapping) indicate that it cannot be merged into the master at this time.

@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 27, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files      2 suites   1h 31m 2s ⏱️
3 116 tests 2 895 ✅ 221 💤 0 ❌
3 118 runs  2 895 ✅ 223 💤 0 ❌

Results for commit f9352fe.

♻️ This comment has been updated with latest results.

@gregfurman gregfurman marked this pull request as ready for review March 7, 2025 11:43
@gregfurman gregfurman added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Mar 7, 2025
dfangl
dfangl approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member
@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix it!

@gregfurman
Copy link
Contributor Author

@dfangl This minor label job is still failing. Let me rebase and push

@gregfurman gregfurman force-pushed the fix/esm/enable-boff branch from 20d4e1f to f9352fe Compare March 7, 2025 11:50
@gregfurman gregfurman merged commit 2e9b26c into master Mar 7, 2025
31 checks passed
@gregfurman gregfurman deleted the fix/esm/enable-boff branch March 7, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@gregfurman gregfurman

Labels
aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases type: bug Bug report
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@gregfurman @dfangl @localstack-bot
0