8000 CFn: populate APIGW regional* properties by simonrw · Pull Request #12320 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CFn: populate APIGW regional* properties #12320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

CFn: populate APIGW regional* properties #12320

merged 1 commit into from
Mar 4, 2025

Conversation

simonrw
Copy link
Contributor
@simonrw simonrw commented Feb 28, 2025

Motivation

A customer provided a template where they used RegionalDomainName and RegionalHostedZoneId, but these values are not populated correctly in the APIGW CFn resource provider

Changes

Populate these two fields from the response if possible, but fall back to the distribution values if not present

Testing

A CFn test is implemented in the private repository as creating domain names is a Pro feature

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Feb 28, 2025
@simonrw simonrw self-assigned this Feb 28, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   29m 22s ⏱️ - 1h 26m 56s
1 069 tests  - 3 035  1 004 ✅  - 2 768  65 💤  - 267  0 ❌ ±0 
1 071 runs   - 3 035  1 004 ✅  - 2 768  67 💤  - 267  0 ❌ ±0 

Results for commit 42e02dd. ± Comparison against base commit 4285fb1.

This pull request removes 3035 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@simonrw simonrw marked this pull request as ready for review March 2, 2025 19:00
bentsku
bentsku approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor
@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this 💯

@simonrw simonrw merged commit f48e6bd into master Mar 4, 2025
34 checks passed
@simonrw simonrw deleted the fix/apigw/cfn/regional-domain-name branch March 4, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@cloutierMat cloutierMat Awaiting requested review from cloutierMat cloutierMat is a code owner

Assignees

@simonrw simonrw

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @bentsku
0