8000 CloudFormation: [POC] Support Update Graph Modeling of Mappings and FindInMap by MEPalma · Pull Request #12432 · localstack/localstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CloudFormation: [POC] Support Update Graph Modeling of Mappings and FindInMap #12432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

CloudFormation: [POC] Support Update Graph Modeling of Mappings and FindInMap #12432

merged 1 commit into from
Mar 31, 2025

Conversation

MEPalma
Copy link
Contributor
@MEPalma MEPalma commented Mar 24, 2025

…indinmap

Motivation

Currently, the POC Update Graph approach to modeling CloudFormation templates does not support CloudFormation Mappings. In addition, intrinsic functions that depend on mapping lookups (Fn::FindInMap) is also unsupported in the modeling layer, which restricted the accuracy of the update graph and impacted downstream processes relying on this data. This PR introduces initial support for Mappings and Fn::FindInMap modeling, ensuring that such constructs are correctly parsed, modeled, and propagated through the update graph. The changes also add support for change set describe workflows involving maps. Relevant initial unit tests have been included to validate these enhancements.

Changes

  • Added support for modeling CloudFormation Mappings within the Update Graph
  • Implemented modeling support for the intrinsic function Fn::FindInMap
  • Added support for Update Graph descriptions of changes in mappings through Fn::FindInMap

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Mar 24, 2025
@MEPalma MEPalma added this to the Playground milestone Mar 24, 2025
@MEPalma MEPalma self-assigned this Mar 24, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   20m 22s ⏱️ - 1h 29m 35s
422 tests  - 3 883  310 ✅  - 3 674  112 💤  - 209  0 ❌ ±0 
424 runs   - 3 883  310 ✅  - 3 674  114 💤  - 209  0 ❌ ±0 

Results for commit dbca36f. ± Comparison against base commit 0d63c5e.

This pull request removes 3883 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@MEPalma MEPalma mentioned this pull request Mar 27, 2025
Merged
simonrw
simonrw approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor
@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding mapping support

@MEPalma MEPalma merged commit 04af669 into master Mar 31, 2025
34 checks passed
@MEPalma MEPalma deleted the MEP-CFN-POC-mapping_findinmap branch March 31, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @simonrw
0