8000 Extract HipChat plugin by matthutchinson · Pull Request #358 · lolcommits/lolcommits · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extract HipChat plugin #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2017
Merged

Extract HipChat plugin #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7455cda
extract hipchat plugin
matthutchinson Oct 14, 2017
08c404a
ignore Rubocop gemspec cop
matthutchinson Oct 26, 2017
51bcdb7
fix features, peg cucumber to 2.4.0
matthutchinson Oct 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ Layout/IndentHeredoc:
Style/PercentLiteralDelimiters:
Enabled: false

Gemspec/OrderedDependencies:
Enabled: false

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
Expand Down
1 change: 0 additions & 1 deletion lib/lolcommits.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
require 'lolcommits/plugin/lol_yammer'
require 'lolcommits/plugin/lol_protonet'
require 'lolcommits/plugin/lol_flowdock'
require 'lolcommits/plugin/lol_hipchat'

# require runner after all the plugins have been required
require 'lolcommits/runner'
124 changes: 0 additions & 124 deletions lib/lolcommits/plugin/lol_hipchat.rb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lolcommits.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ POSTINSTALL
# hold back upgrading (and why)
s.add_development_dependency('aruba', '=0.6.2') # upgrading requires a lot of test code changes
s.add_development_dependency('rake', '=10.5.0') # ~> 11+ introduces lots of warnings from other deps
s.add_development_dependency('cucumber', '~> 2.4.0') # > 2.4 breaks aruba, since aruba_timeout_seconds not set
s.add_runtime_dependency('net-http-persistent', '=2.9.4') # ~> 3+ requires Ruby 2.1
s.add_runtime_dependency('public_suffix', '~>2.0.0') # ~> 3+ requires Ruby 2.1

Expand Down Expand Up @@ -78,5 +79,4 @@ POSTINSTALL
s.add_development_dependency('minitest')
s.add_development_dependency('coveralls')
s.add_development_dependency('ffaker')
s.add_development_dependency('cucumber')
end
0