8000 Better plugin config flow by matthutchinson · Pull Request #363 · lolcommits/lolcommits · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Better plugin config flow #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Better plugin config flow #363

merged 2 commits into from
Dec 14, 2017

Conversation

matthutchinson
Copy link
Member

Changes the plugin config flow slightly, so any reply other than 'true' (for enabled) will result in the plugin being disabled and configuration prompting to stop.

This PR also brings us in line with the latest guidelines from rubocop

@matthutchinson matthutchinson merged commit 2d61fd2 into master Dec 14, 2017
@matthutchinson matthutchinson deleted the better-plugin-config-flow branch January 10, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0