8000 Plugin config improvements by matthutchinson · Pull Request #365 · lolcommits/lolcommits · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Plugin config improvements #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 10, 2018
Merged

Plugin config improvements #365

merged 11 commits into from
Jan 10, 2018

Conversation

matthutchinson
Copy link
Member
@matthutchinson matthutchinson commented Jan 9, 2018 •
edited
Loading

A few improvements when configuring plugins:

  • when listing plugins, you can now see if they are currently enabled (or not)
  • default option hash is now available for use in plugins, with nested config and default values (lolcommits-loltext will be refactored to use this)
  • if valid_configuration? fails, plugin hook fails to execute (as before), and a new warning message is shown
  • Lolcommits::Plugin::ConfigurationHelper now available with parse_user_input method and prompt_autocomplete_hash (a user can tab in cmd line to autocomplete suggested option values from a list)

⚠️ NOTE: This PR changes the enabled option from a string key, to a symbol. Most of the existing plugin gems will be updated to do the same and make use of the other changes.

This PR also bumps up the Travis Ruby versions in .travis.yml

@matthutchinson matthutchinson force-pushed the plugin-config-improvements branch from f28de6e to 442922b Compare January 9, 2018 21:38
@matthutchinson matthutchinson force-pushed the plugin-config-improvements branch from 39eb636 to d94e48b Compare January 10, 2018 16:02
@matthutchinson matthutchinson merged commit cc3edf3 into master Jan 10, 2018
@matthutchinson matthutchinson deleted the plugin-config-improvements branch January 10, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature 48E1 plugin refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthutchinson
0