Add Qdrant VS #153
Merged
Add Qdrant VS #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amogh Tantradi <amogh_t2003@berkeley.edu>
vincent-4
reviewed
Mar 15, 2025
| # Delete collection if it already exists | ||
| try: | ||
| self.client.delete_collection(collection_name=index_dir) | ||
| except Exception: |
There was a problem hiding this comment.
Qdrant should have an exception for not found or something similar, maybe consider catching that and raise anything else?
|
this looks like a good start! the main things missing are unit tests (eg test index creation, reloading the index following to the df after its been created, simple sem_search, sem_search after filtering, sem_join, and sem_cluster_by) and docs. Also if we can't retrieve vectors by ids from the index, then we should raise a warning about that and how it limits usage for sem_cluster_by and possibly sem_filter / sem_join (when using retrieval-based proxies), but it looks like its possible for Qdrant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #111 with some patches. Added an example of usage.