Update sem_map
#173
Open
Update sem_map
#173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentzed
commented
Apr 23, 2025
| model_kwargs = {"progress_bar_desc": progress_bar_desc} | ||
|
|
||
| # Add sampling parameters | ||
| model_kwargs["n"] = nsample |
There was a problem hiding this comment.
Pyright checks:
/Users/mrnoodles/Github/Open Source/lotus/lotus/sem_ops/sem_map.py:69:5 - error: Argument of type "int" cannot be assigned to parameter "value" of type "str" in function "__setitem__"
"int" is not assignable to "str" (reportArgumentType)
/Users/mrnoodles/Github/Open Source/lotus/lotus/sem_ops/sem_map.py:72:9 - error: Argument of type "float" cannot be assigned to parameter "value" of type "str" in function "__setitem__"
"float" is not assignable to "str" (reportArgumentType)"
I think this is ok since it's model kwargs, but I can do some digging to fix
|
Nice work on this! It would make sense to take an optional temperature argument here so that the user doesn't have to reset it manually by reconfiguring the LM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy:
pytest .github/tests/lm_tests.py::test_sem_map_nsample .github/tests/lm_tests.py::test_sem_map_nsample_with_returns .github/tests/lm_tests.py::test_sem_map_temp -v